Skip to content

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HassanOHOsman wants to merge 93 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293

HassanOHOsman wants to merge 93 commits into from

Conversation

@HassanOHOsman
Copy link

@HassanOHOsman HassanOHOsman commented Dec 8, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

This PR contains my solutions to all the "Prep Exercises" in Sprint 5 of the "Tools" module.

@HassanOHOsman
create a dir for my exercises and a .py file for exercise 1
d7860a4
@HassanOHOsman
provide 2 solutions to exercise 1
c6edd33
@HassanOHOsman
rename file
bbca608
@HassanOHOsman
create file to exercise 1
597f47e
@HassanOHOsman
add exercise 1 question
adec5ea
@HassanOHOsman
answer to Q 1 of exercises
c202adf
@HassanOHOsman
create venv
4917fe7
@HassanOHOsman
install mypy
ab0e5d5
@HassanOHOsman
create a test file to test some py code
b0143fd
@HassanOHOsman
adding type annotation to the function def to avoid getting errors wh…
5c7d52c 
…en running mypy
@HassanOHOsman
re-add type annotation to function def
6803aed
@HassanOHOsman
delete the test file
dd86ef8
@HassanOHOsman
create a .py file for exercise 3
9df4222
@HassanOHOsman
type annotate open_account function return
bf4f92c
@HassanOHOsman
type anno. open_account arguments
0b58dee
@HassanOHOsman
add a return line to function open-account
e133ed6
@HassanOHOsman
type anno. return for function sum_balance
0692d80
@HassanOHOsman
type anno. the argument accounts of function sum_balances
93e8215
@HassanOHOsman
type annotate the argument and return for function format_pence_as_st…
eaa2fa4 
…ring
@HassanOHOsman
adding the missing third argument: "balances" to the 2 open_account f…
b7f3ae2 
…unction calls
@HassanOHOsman
updated all the int values to float
530b650
@HassanOHOsman
updating type anno. and making a few changes
b55e70c
@HassanOHOsman
correcting syntax error in sum_balances func and the name of the 1st …
ccce3db 
…argument in open_account
@HassanOHOsman
fixed bugs in the 2 open_account fuc calls at the bottom
bb87b72
@HassanOHOsman
corrected the name bug for the format_pence_as_string call at the bottom
ce70769
@HassanOHOsman
create .py file for exercise 4
a70ac33
@HassanOHOsman
add solution to problem 4
550f320
@HassanOHOsman
create .py file for exercise 5
ee4aae2
@HassanOHOsman
add a question to problem 5
dc9fa85
@HassanOHOsman
create a new function as per exercise 5 requirments
23cf5c5
@HassanOHOsman
allowing OS to be in lowercase too
e981618
@HassanOHOsman
updating code to validate types
2702dd9
@HassanOHOsman
updated person_builder func validation for fields
b0de1ee
@HassanOHOsman
remove type checking/valdiation lines as they are not working
f073259
@HassanOHOsman
adding an OS with a limited list of avaible options
1a0f28f
@HassanOHOsman
update rest of code as per enums importation
4a3d056
@HassanOHOsman
moving OS class at the top so OS field erro oin laptop class is avoided
b1e5f1d
@HassanOHOsman
add type validation measures
eb1be83
@HassanOHOsman
CREATE AND UPDATE LAPTOP COUNTER FUNCTION
6c155a8
@HassanOHOsman
add a helper function parse_os_input to handle a variety of ways end …
b469b8d 
…user can type an OS
@HassanOHOsman
update counter function to handle different cases as per number of la…
5c05376 
…ptops
@HassanOHOsman
improve readability of output for counter OS
6cf094f
@HassanOHOsman
input user message when there are more than a laptop of their chosen OS
60782dd
@HassanOHOsman
corrected laptop_counter func
275feb8
@HassanOHOsman
create OS counter to find out if more OS other than end user's preffe…
5c49864 
…red OS avaiable and display an offer message
@HassanOHOsman
improve more_avaiable_function
8cd2513
@HassanOHOsman
create .py file for exercise 12
25307d4
@HassanOHOsman
add Q12 to the .py file
43db6cf
@HassanOHOsman
add prediction
ff5238e
@HassanOHOsman
comment problematic lines
40d209b
@HassanOHOsman HassanOHOsman added 📅 Sprint 5 Assigned during Week 5 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 8, 2025
@LonMcGregor
Copy link

LonMcGregor commented Jan 14, 2026

There are a lot of files comitted here, can you take a look and figure out why that is happening?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026
@HassanOHOsman
Copy link
Author

HassanOHOsman commented Jan 14, 2026

There are a lot of files comitted here, can you take a look and figure out why that is happening?

Yes, I just ignored the .venv so that it's easy for you to navigate through. Please let me know if you need anything else :)

@HassanOHOsman HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HassanOHOsman @LonMcGregor